Update/dmsg serve #165
Closed
Update/dmsg serve #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kifen
requested review from
evanlinjin,
Darkren,
nkryuchkov and
jdknives
and removed request for
Darkren
|
Binary uploaded. |
nkryuchkov
suggested changes
Feb 21, 2020
pkg/snet/snettest/env.go
Outdated
| @@ -137,7 +137,7 @@ func createDmsgSrv(t *testing.T, dc disc.APIClient) (srv *dmsg.Server, srvErr <- | |||
| srv = dmsg.NewServer(pk, sk, dc) | |||
| errCh := make(chan error, 1) | |||
| go func() { | |||
| errCh <- srv.Serve(l, "") | |||
| errCh <- srv.Serve(l, "", 10) | |||
There was a problem hiding this comment.
Is the signature of srv.Serve already changed somewhere? What do you think of extracting 10 to a constant with a describing name? I think it might improve the code readability if one can see what 10 means.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check? yesFixes #
Changes:
How to test this PR: